New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELEKTRA_PLUGIN_NAME #1042
Comments
@petermax2 Do you maybe want to implement this? |
Yes, you can assign me if the implementation is not time critical. At the moment I have not so much spare time. |
Thank you for working on this! The actual reason to do this, is that every plugin has something like CRYPTO_PLUGIN_FUNCTION available and that CRYPTO_PLUGIN_FUNCTION is not needed anymore. Btw. ARG_COMPILE_DEFINITIONS cannot be modified (due to restore_variable), so simply add further definitions in cmake/Modules/LibAddPlugin.cmake line 155 (where COMPILE_DEFINITIONS are defined). |
It works for "regular" plugins (without compilation variant), now I'm looking into plugin variants. |
Great that you have progress! |
Provides ELEKTRA_PLUGIN_NAME and ELEKTRA_PLUGIN_NAME_C as compiler definitions via CMake. See ElektraInitiative#1042 for details.
Provides ELEKTRA_PLUGIN_NAME and ELEKTRA_PLUGIN_NAME_C as compiler definitions via CMake. See ElektraInitiative#1042 for details.
Provides ELEKTRA_PLUGIN_NAME and ELEKTRA_PLUGIN_NAME_C as compiler definitions via CMake. See ElektraInitiative#1042 for details.
Progress so far#2360 : The CMake module
The removal of unnecessary parameters of |
Thanks to the feedback by @sanssecours ! See ElektraInitiative#1042 .
Provides ELEKTRA_PLUGIN_NAME and ELEKTRA_PLUGIN_NAME_C as compiler definitions via CMake. See ElektraInitiative#1042 for details.
Thanks to the feedback by @sanssecours ! See ElektraInitiative#1042 .
it is provided by the build system automatically. See ElektraInitiative#1042 for further details.
So ELEKTRA_PLUGIN_EXPORT and ELEKTRA_README are the last left-overs? |
Yes, should be very easy and straight-forward now that |
See ElektraInitiative#1042 for details.
See ElektraInitiative#1042 for details.
See ElektraInitiative#1042 for details.
…ADME See ElektraInitiative#1042 for details.
We finally did it! |
Build system should provide:
Then ELEKTRA_PLUGIN_EXPORT, ELEKTRA_PLUGIN_FUNCTION, ELEKTRA_README would have one paramter less.
The text was updated successfully, but these errors were encountered: